Refactor of Generation class and inject path into Launch process #650
Conversation
REBASEME: moar mpi REBASEME: fmt mpi
smartsim/experiment.py
Outdated
| @@ -179,13 +181,23 @@ def start(self, *jobs: Job) -> tuple[LaunchedJobID, ...]: | |||
| jobs that can be used to query or alter the status of that | |||
| particular execution of the job. | |||
| """ | |||
| return self._dispatch(dispatch.DEFAULT_DISPATCHER, *jobs) | |||
| run_id = datetime.datetime.now().replace(microsecond=0).isoformat() | |||
| """Create the run id""" | |||
There was a problem hiding this comment.
I think for function variables it may be more natural for the comments to come before the variable if they are going to be added. I'm not seeing in vscode that they render as a comment
There was a problem hiding this comment.
If we are going to put these comments ahead of the variable as non-docstrings, can we make these look like traditional comments?
| """Create the run id""" | |
| # Create the run id |
In theory it makes saves us a no-op instruction at runtime, but in practice I just think it looks nicer, hahaha
smartsim/experiment.py
Outdated
| """ | ||
| job_type = f"{job.__class__.__name__.lower()}s" | ||
| job_path = pathlib.Path(root) / f"{job_type}/{job.name}-{job_index}" | ||
| job_path.mkdir(exist_ok=True, parents=True) |
There was a problem hiding this comment.
I think we need to make a ticket to inject a launcher in here. I think we want to use the entrypoints to enable remote jobs.
smartsim/experiment.py
Outdated
| @@ -179,13 +181,23 @@ def start(self, *jobs: Job) -> tuple[LaunchedJobID, ...]: | |||
| jobs that can be used to query or alter the status of that | |||
| particular execution of the job. | |||
| """ | |||
| return self._dispatch(dispatch.DEFAULT_DISPATCHER, *jobs) | |||
| run_id = datetime.datetime.now().replace(microsecond=0).isoformat() | |||
| """Create the run id""" | |||
There was a problem hiding this comment.
If we are going to put these comments ahead of the variable as non-docstrings, can we make these look like traditional comments?
| """Create the run id""" | |
| # Create the run id |
In theory it makes saves us a no-op instruction at runtime, but in practice I just think it looks nicer, hahaha
amandarichardsonn
merged commit 52cd8ec
into
CrayLabs:smartsim-refactor
No description provided.