Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for ShellLauncher & additional shell launch context #671

Merged

remove the zip

aa00b09
Select commit
Loading
Failed to load commit list.
Merged

Unit tests for ShellLauncher & additional shell launch context #671

remove the zip
aa00b09
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 28, 2024 in 0s

42.35% (target 0.00%)

View this Pull Request on Codecov

42.35% (target 0.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.35%. Comparing base (cce16e6) to head (aa00b09).
Report is 4 commits behind head on smartsim-refactor.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #671      +/-   ##
=====================================================
+ Coverage              40.45%   42.35%   +1.89%     
=====================================================
  Files                    110      109       -1     
  Lines                   7326     7062     -264     
=====================================================
+ Hits                    2964     2991      +27     
+ Misses                  4362     4071     -291     
Files Coverage Δ
smartsim/_core/commands/command.py 97.36% <100.00%> (+1.71%) ⬆️
smartsim/_core/commands/commandList.py 95.00% <100.00%> (+4.52%) ⬆️
smartsim/_core/dispatch.py 95.87% <100.00%> (-0.97%) ⬇️
smartsim/_core/generation/generator.py 97.91% <100.00%> (+0.13%) ⬆️
smartsim/_core/launcher/dragon/dragonLauncher.py 27.11% <100.00%> (+0.41%) ⬆️
smartsim/_core/shell/shellLauncher.py 96.61% <100.00%> (+35.74%) ⬆️
smartsim/experiment.py 81.55% <100.00%> (ø)
smartsim/launchable/baseJobGroup.py 79.41% <ø> (ø)
smartsim/launchable/colocatedJobGroup.py 88.00% <ø> (ø)
smartsim/launchable/jobGroup.py 92.30% <ø> (ø)

... and 2 files with indirect coverage changes