Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensemble Refactor #686

Merged
merged 30 commits into from
Sep 5, 2024
Merged

Conversation

juliaputko
Copy link
Contributor

No description provided.

@juliaputko juliaputko requested a review from MattToast August 28, 2024 22:58
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 89.55224% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.95%. Comparing base (cce16e6) to head (ca8654f).
Report is 19 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/entity/ensemble.py 89.23% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #686      +/-   ##
=====================================================
+ Coverage              40.45%   43.95%   +3.49%     
=====================================================
  Files                    110      110              
  Lines                   7326     7134     -192     
=====================================================
+ Hits                    2964     3136     +172     
+ Misses                  4362     3998     -364     
Files with missing lines Coverage Δ
smartsim/entity/application.py 82.60% <100.00%> (ø)
smartsim/entity/ensemble.py 91.30% <89.23%> (-5.84%) ⬇️

... and 6 files with indirect coverage changes

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor nits and docs requests, but nothing worth holding approval up over! LGTM!!

smartsim/entity/ensemble.py Outdated Show resolved Hide resolved
smartsim/entity/ensemble.py Outdated Show resolved Hide resolved
smartsim/entity/ensemble.py Outdated Show resolved Hide resolved
smartsim/entity/ensemble.py Show resolved Hide resolved
Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions/comments

smartsim/entity/ensemble.py Outdated Show resolved Hide resolved
@juliaputko juliaputko merged commit 0175b6b into CrayLabs:smartsim-refactor Sep 5, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants