Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camel Case to Snake Case #711

Merged

Conversation

amandarichardsonn
Copy link
Contributor

This PR converts Camel case files to Snake case.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 85.14851% with 15 lines in your changes missing coverage. Please review.

Project coverage is 43.95%. Comparing base (cce16e6) to head (f218598).
Report is 19 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/_core/launcher/dragon/dragon_backend.py 0.00% 5 Missing ⚠️
smartsim/_core/launcher/dragon/dragon_connector.py 16.66% 5 Missing ⚠️
smartsim/entity/ensemble.py 0.00% 1 Missing ⚠️
smartsim/entity/entity.py 50.00% 1 Missing ⚠️
smartsim/experiment.py 50.00% 1 Missing ⚠️
smartsim/launchable/base_job.py 0.00% 1 Missing ⚠️
smartsim/launchable/mpmd_job.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #711      +/-   ##
=====================================================
+ Coverage              40.45%   43.95%   +3.49%     
=====================================================
  Files                    110      110              
  Lines                   7326     7133     -193     
=====================================================
+ Hits                    2964     3135     +171     
+ Misses                  4362     3998     -364     
Files with missing lines Coverage Δ
smartsim/_core/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/arguments/shell.py 100.00% <100.00%> (ø)
smartsim/_core/commands/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/commands/command_list.py 95.00% <ø> (ø)
smartsim/_core/commands/launch_commands.py 100.00% <100.00%> (ø)
smartsim/_core/control/controller.py 16.35% <100.00%> (+1.17%) ⬆️
smartsim/_core/control/job_manager.py 22.92% <100.00%> (ø)
smartsim/_core/control/preview_renderer.py 41.33% <100.00%> (ø)
smartsim/_core/launcher/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/launcher/dragon/dragon_launcher.py 27.52% <100.00%> (ø)
... and 47 more

... and 3 files with indirect coverage changes

Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you!

@amandarichardsonn amandarichardsonn merged commit f49fde3 into CrayLabs:smartsim-refactor Sep 18, 2024
36 of 37 checks passed
@amandarichardsonn amandarichardsonn deleted the snake_case branch September 18, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants