-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for sequences into exp.start(), and unpack iterables #712
Allow for sequences into exp.start(), and unpack iterables #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor typing suggestions, but otherwise looks about ready to go on my end!!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #712 +/- ##
=====================================================
+ Coverage 40.45% 46.30% +5.84%
=====================================================
Files 110 107 -3
Lines 7326 6455 -871
=====================================================
+ Hits 2964 2989 +25
+ Misses 4362 3466 -896
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Got some suggestions for writing test lets go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more small nits in addition to Amanda's comments. Overall, looking really good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of last minute nits about some test ids, I agree with the need for an additional test to test unpack
directly, but nothing there is worth holding approval up over!
LGTM!! Thanks for all the hard work on this one!!
Co-authored-by: Matt Drozt <[email protected]>
Co-authored-by: Matt Drozt <[email protected]>
Co-authored-by: Matt Drozt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.