Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for sequences into exp.start(), and unpack iterables #712

Merged
merged 11 commits into from
Oct 4, 2024

Conversation

juliaputko
Copy link
Contributor

No description provided.

smartsim/experiment.py Outdated Show resolved Hide resolved
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor typing suggestions, but otherwise looks about ready to go on my end!!

smartsim/experiment.py Outdated Show resolved Hide resolved
smartsim/experiment.py Outdated Show resolved Hide resolved
smartsim/experiment.py Outdated Show resolved Hide resolved
smartsim/experiment.py Outdated Show resolved Hide resolved
tests/test_experiment.py Outdated Show resolved Hide resolved
tests/test_experiment.py Outdated Show resolved Hide resolved
tests/test_experiment.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.30%. Comparing base (cce16e6) to head (0d60164).
Report is 17 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/_core/utils/helpers.py 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #712      +/-   ##
=====================================================
+ Coverage              40.45%   46.30%   +5.84%     
=====================================================
  Files                    110      107       -3     
  Lines                   7326     6455     -871     
=====================================================
+ Hits                    2964     2989      +25     
+ Misses                  4362     3466     -896     
Files with missing lines Coverage Δ
smartsim/experiment.py 86.61% <100.00%> (+5.06%) ⬆️
smartsim/_core/utils/helpers.py 40.16% <87.50%> (-0.02%) ⬇️

... and 11 files with indirect coverage changes

Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Got some suggestions for writing test lets go!

smartsim/experiment.py Outdated Show resolved Hide resolved
smartsim/experiment.py Outdated Show resolved Hide resolved
smartsim/experiment.py Outdated Show resolved Hide resolved
smartsim/_core/utils/helpers.py Show resolved Hide resolved
smartsim/_core/utils/helpers.py Outdated Show resolved Hide resolved
tests/test_experiment.py Outdated Show resolved Hide resolved
tests/test_experiment.py Outdated Show resolved Hide resolved
tests/test_experiment.py Outdated Show resolved Hide resolved
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more small nits in addition to Amanda's comments. Overall, looking really good!

smartsim/_core/utils/helpers.py Outdated Show resolved Hide resolved
smartsim/experiment.py Outdated Show resolved Hide resolved
smartsim/experiment.py Outdated Show resolved Hide resolved
tests/test_experiment.py Outdated Show resolved Hide resolved
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of last minute nits about some test ids, I agree with the need for an additional test to test unpack directly, but nothing there is worth holding approval up over!

LGTM!! Thanks for all the hard work on this one!!

tests/test_experiment.py Outdated Show resolved Hide resolved
tests/test_experiment.py Outdated Show resolved Hide resolved
tests/test_experiment.py Outdated Show resolved Hide resolved
smartsim/_core/utils/helpers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliaputko juliaputko merged commit dbf7b72 into CrayLabs:smartsim-refactor Oct 4, 2024
34 of 35 checks passed
@juliaputko juliaputko deleted the starttuples branch October 4, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants