Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensemble Move short-task #714

Merged

Conversation

amandarichardsonn
Copy link
Contributor

The Ensemble class is moved to core/builder/ in this PR -> as_jobs is changed to build_jobs -> and documentation is updated.

smartsim/entity/__init__.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.28%. Comparing base (cce16e6) to head (8144d51).
Report is 15 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/_core/utils/serialize.py 0.00% 2 Missing ⚠️
smartsim/entity/entity.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #714      +/-   ##
=====================================================
+ Coverage              40.45%   46.28%   +5.82%     
=====================================================
  Files                    110      107       -3     
  Lines                   7326     6462     -864     
=====================================================
+ Hits                    2964     2991      +27     
+ Misses                  4362     3471     -891     
Files with missing lines Coverage Δ
smartsim/_core/control/manifest.py 48.64% <100.00%> (+2.15%) ⬆️
smartsim/_core/launcher/step/step.py 42.85% <100.00%> (+0.17%) ⬆️
smartsim/builders/__init__.py 100.00% <100.00%> (ø)
smartsim/builders/ensemble.py 91.39% <100.00%> (ø)
smartsim/builders/utils/strategies.py 100.00% <ø> (ø)
smartsim/entity/__init__.py 100.00% <ø> (ø)
smartsim/entity/entity.py 75.00% <50.00%> (+9.09%) ⬆️
smartsim/_core/utils/serialize.py 34.00% <0.00%> (-0.70%) ⬇️

... and 8 files with indirect coverage changes

Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amandarichardsonn amandarichardsonn merged commit 4faf95c into CrayLabs:smartsim-refactor Sep 23, 2024
34 of 35 checks passed
@amandarichardsonn amandarichardsonn deleted the ensemble_move branch September 23, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants