-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensemble Move short-task #714
Merged
amandarichardsonn
merged 6 commits into
CrayLabs:smartsim-refactor
from
amandarichardsonn:ensemble_move
Sep 23, 2024
Merged
Ensemble Move short-task #714
amandarichardsonn
merged 6 commits into
CrayLabs:smartsim-refactor
from
amandarichardsonn:ensemble_move
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellis13
suggested changes
Sep 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #714 +/- ##
=====================================================
+ Coverage 40.45% 46.28% +5.82%
=====================================================
Files 110 107 -3
Lines 7326 6462 -864
=====================================================
+ Hits 2964 2991 +27
+ Misses 4362 3471 -891
|
mellis13
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amandarichardsonn
merged commit Sep 23, 2024
4faf95c
into
CrayLabs:smartsim-refactor
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ensemble class is moved to core/builder/ in this PR -> as_jobs is changed to build_jobs -> and documentation is updated.