-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application.files refactor #732
Application.files refactor #732
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #732 +/- ##
=====================================================
+ Coverage 40.45% 47.32% +6.87%
=====================================================
Files 110 109 -1
Lines 7326 6573 -753
=====================================================
+ Hits 2964 3111 +147
+ Misses 4362 3462 -900
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Just dropping some initial feedback so that we can start ironing out some of the finer points, but otherwise this looking really good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last small request, but otherwise LGTM!!
a39246e
into
CrayLabs:smartsim-refactor
This PR adds a operations.py file that holds that holds the functionality that allows user to add files to an Application.