Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core refactor merged into mli-feature #752

Closed
wants to merge 112 commits into from
Closed

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Oct 17, 2024

No description provided.

amandarichardsonn and others added 30 commits May 2, 2024 16:55
Move the test suite used for SmartSim v0.X.Y to a `tests/_legacy` dir.
This directory is explicitly skipped during test collection as these
tests are not expected to pass as SmartSim transitions to a new user
facing and core API.

Additional changes to CI to make sure the feature branch continues
to pass while in a chaotic development state.

[ committed by @MattToast ]
[ reviewed by @amandarichardsonn ]
Fixed inconsistency when adding run arguments N, nodes, or ntasks, to a RunSettings object with leading `-` characters.

 [ committed by @juliaputko ]
 [ reviewed by @amandarichardsonn  ]
BaseJobGroup, JobGroup and ColocatedJobGroup skeletons added.

[ Committed by @amandarichardsonn ]
[ Reviewed by @juliaputko ]
This PR adds the Capnproto schemas and initial MessageHandler class and
tests.
This PR contains an ML worker manager MVP. The worker manager executes a
single-threaded version of the planned ML pipeline for a single worker
instance.

[ committed by @ankona ]
[ approved by @mellis13 ]
This PR removes `device` from the schemas, MessageHandler, and tests.
Add `Model` schema with model metadata.

[ committed by @AlyssaCote ]
[ approved by @ankona ]
@ankona ankona marked this pull request as ready for review October 17, 2024 21:32
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 48.05777% with 1043 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.0@8a19dee). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/experiment.py 22.93% 84 Missing ⚠️
smartsim/_core/generation/generator.py 36.20% 74 Missing ⚠️
smartsim/builders/ensemble.py 44.34% 64 Missing ⚠️
smartsim/entity/application.py 44.11% 57 Missing ⚠️
smartsim/_core/utils/helpers.py 32.05% 53 Missing ⚠️
smartsim/database/orchestrator.py 18.75% 52 Missing ⚠️
smartsim/settings/arguments/launch/mpi.py 43.02% 49 Missing ⚠️
smartsim/_core/shell/shell_launcher.py 45.67% 44 Missing ⚠️
smartsim/settings/launch_settings.py 41.66% 42 Missing ⚠️
smartsim/builders/utils/strategies.py 39.70% 41 Missing ⚠️
... and 45 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             v1.0     #752   +/-   ##
=======================================
  Coverage        ?   25.43%           
=======================================
  Files           ?      131           
  Lines           ?     9173           
  Branches        ?        0           
=======================================
  Hits            ?     2333           
  Misses          ?     6840           
  Partials        ?        0           
Files with missing lines Coverage Δ
smartsim/_core/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/arguments/shell.py 100.00% <100.00%> (ø)
smartsim/_core/commands/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/config/config.py 78.87% <100.00%> (ø)
smartsim/_core/control/__init__.py 100.00% <ø> (ø)
smartsim/_core/launcher/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/launcher/dragon/dragon_sockets.py 25.39% <100.00%> (ø)
smartsim/_core/launcher/sge/sge_commands.py 33.33% <ø> (ø)
smartsim/_core/launcher/sge/sge_parser.py 23.07% <ø> (ø)
smartsim/_core/launcher/step/__init__.py 100.00% <100.00%> (ø)
... and 82 more

@ankona ankona changed the base branch from mli-feature to v1.0 October 19, 2024 18:08
@ankona ankona force-pushed the mli-merge branch 2 times, most recently from 2dc2483 to 54ca522 Compare October 21, 2024 18:17
@ankona ankona closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants