-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SmartSim to use Dragon V0.10 #753
base: develop
Are you sure you want to change the base?
Conversation
1fa370a
to
de40bc9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #753 +/- ##
===========================================
- Coverage 83.91% 81.82% -2.09%
===========================================
Files 83 84 +1
Lines 6284 7081 +797
===========================================
+ Hits 5273 5794 +521
- Misses 1011 1287 +276
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@MattToast there have been some updates to Dragon's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor changes need to happen before this can be merged. They include:
- change pinned version
- add arg to ProcessGroup to avoid failing on process exception
- handle exceptions when stopping groups and redir workers
@al-rigazzi By all means! Feel free to take over ownership of this branch and push whatever changes are necessary!! |
Update SmartSim to use Dragon V0.10 by:
smart build --dragon ...
to fetch Dragon V0.10 once all required assets are hosted