Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge core refactor into v1.0 feature branch #756

Merged
merged 118 commits into from
Oct 28, 2024

remove refs to `installed_redisai_backends`

629baa5
Select commit
Loading
Failed to load commit list.
Merged

Merge core refactor into v1.0 feature branch #756

remove refs to `installed_redisai_backends`
629baa5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2024 in 1s

58.96% (target 0.00%)

View this Pull Request on Codecov

58.96% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 83.09791% with 347 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.0@8a19dee). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/database/orchestrator.py 18.75% 52 Missing ⚠️
smartsim/_core/control/manifest.py 36.36% 28 Missing ⚠️
smartsim/_core/utils/helpers.py 62.16% 28 Missing ⚠️
smartsim/_core/launcher/dragon/dragon_launcher.py 53.19% 22 Missing ⚠️
smartsim/_core/utils/serialize.py 13.33% 13 Missing ⚠️
smartsim/_core/launcher/dragon/dragon_connector.py 21.42% 11 Missing ⚠️
smartsim/_core/launcher/step/step.py 31.25% 11 Missing ⚠️
smartsim/_core/utils/telemetry/collector.py 21.42% 11 Missing ⚠️
smartsim/_core/launcher/step/mpi_step.py 37.50% 10 Missing ⚠️
smartsim/settings/arguments/batch_arguments.py 74.28% 9 Missing ⚠️
... and 40 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             v1.0     #756   +/-   ##
=======================================
  Coverage        ?   58.96%           
=======================================
  Files           ?      142           
  Lines           ?     9126           
  Branches        ?        0           
=======================================
  Hits            ?     5381           
  Misses          ?     3745           
  Partials        ?        0
Files with missing lines Coverage Δ
smartsim/_core/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/arguments/shell.py 100.00% <100.00%> (ø)
smartsim/_core/commands/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/commands/launch_commands.py 100.00% <100.00%> (ø)
smartsim/_core/config/config.py 81.69% <100.00%> (ø)
smartsim/_core/control/__init__.py 100.00% <ø> (ø)
smartsim/_core/control/interval.py 100.00% <100.00%> (ø)
smartsim/_core/generation/generator.py 100.00% <100.00%> (ø)
smartsim/_core/generation/operations/operations.py 100.00% <100.00%> (ø)
...rtsim/_core/generation/operations/utils/helpers.py 100.00% <100.00%> (ø)
... and 85 more
View more details on Codecov