Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request dispatcher test #776

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Fix request dispatcher test #776

merged 3 commits into from
Nov 4, 2024

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Oct 31, 2024 •
edited
Loading

This PR includes the following fixes for dragon tests:

  1. Remove a duplicate of test_dragon_comm_utils.py
  2. Refactor test_request_dispatcher.py to run without multiprocessing

@ankona ankona changed the base branch from develop to v1.0 October 31, 2024 17:06
@ankona ankona force-pushed the test-importpath branch 3 times, most recently from 87be44b to 77b9cc2 Compare October 31, 2024 21:03
@ankona ankona changed the title test build agent execution of dragon tests [nomerge] Fix request dispatcher test Oct 31, 2024
AlyssaCote
AlyssaCote approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@AlyssaCote AlyssaCote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Quick question that I doesn't hold up my approval. Should we create a ticket to solve the test_worker_manager import issues as well?

@ankona ankona merged commit 2e9a384 into v1.0 Nov 4, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlyssaCote AlyssaCote AlyssaCote approved these changes

@al-rigazzi al-rigazzi Awaiting requested review from al-rigazzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankona @AlyssaCote