Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geocoder update #87

Closed
wants to merge 5 commits into from
Closed

Geocoder update #87

wants to merge 5 commits into from

Conversation

tabiodun
Copy link

Issuse #84

Changes:

Update Leaflet Maps to use Pitney-Bowes Maps
Create Autocomplete for new Pitney-Bowes Geocoder
Add Autocomplete to address field in event form
Remove unnecessary code
Fix lint and file formatting as much as possible on files I touched
Added e2e tests
Removed references to google maps api

Screens

screenshot 2018-10-20 20 31 45
new geocoder and map

Outstanding Questions

  • Is the potential for better results with this API?
  • The auth token has to be created for every request to the API at the moment. I can't currently see an alternative, but I'm thinking about one
  • I'm currently using a window object to store the instance of the map, there might be a more Vue-y way to do this?

@tabiodun
Update Leaflet Maps to use Pitney-Bowes Maps
43febc8 
Create Autocomplete for new Pitney-Bowes Geocoder
Add Autocomplete to address field in event form
Remove unnecessary code
Fix lint and file formating as much as possible on files I touched

CrisisCleanup/crisiscleanup-3-web#84
@tabiodun
Add e2e tests for new geocoder
fd9ee4e 
CrisisCleanup/crisiscleanup-3-web#84
@tabiodun tabiodun force-pushed the geocoder-update branch 2 times, most recently from 5b1b603 to d55d1ba Compare October 22, 2018 09:54
@tabiodun tabiodun closed this Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tabiodun