Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix src cropper component when replace images, Add examples when cropping images, Add generation default values of method parameters for API #263

Merged

Conversation

MaxymGorn
Copy link
Member

@MaxymGorn MaxymGorn commented Nov 13, 2023

Target

Fix src cropper component when replace images
Add examples when cropping images
Add generation default values of method parameters for API

Open Questions

Checklist

  • Documentation updated
  • Tests cover new or modified code
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New dependencies added
  • Includes breaking changes
  • Version bumped

Visuals

- add generation default values of method parameters for API
@MaxymGorn MaxymGorn added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 13, 2023
@MaxymGorn MaxymGorn enabled auto-merge (squash) November 13, 2023 17:11
@MaxymGorn MaxymGorn changed the title Add examples when cropping images, Add generation default values of method parameters for API Fix src cropper component when replace images, Add examples when cropping images, Add generation default values of method parameters for API Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f40e96) 100.00% compared to head (cc886b1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #263   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          656       657    +1     
  Branches        62        62           
=========================================
+ Hits           656       657    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxymGorn MaxymGorn merged commit a1530d1 into dev Nov 15, 2023
3 checks passed
@MaxymGorn MaxymGorn deleted the feature/add_examples_fix_generation_default)values_for_api branch November 15, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants