Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keepers for newbieVilla #175

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Add keepers for newbieVilla #175

merged 6 commits into from
Oct 16, 2023

Conversation

iavl
Copy link
Member

@iavl iavl commented Oct 11, 2023

Description

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • I have updated the abi and docs
  • I tested locally to make sure this feature/fix works

Which contracts need to be upgraded ?

  • Web3Entry
  • Linklist
  • NewbieVilla
  • Tips
  • ApprovalMintModule
  • LimitedMintModule
  • MintNFT template

@iavl iavl enabled auto-merge October 12, 2023 03:33
Copy link
Member

@Atlasoin Atlasoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should keeper has the permission to call tipxxx?

@iavl
Copy link
Member Author

iavl commented Oct 13, 2023

Should keeper has the permission to call tipxxx?

yeah, I'll fix it.

@iavl iavl requested a review from Atlasoin October 16, 2023 05:59
@iavl iavl added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit e87afca Oct 16, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 16, 2023
* feat: add keepers for newbieVilla

* feat: add test cases

* fix: typo

* feat: update testWithdrawNewbieOutFail

* feat: update docs & newbieVilla storage layout

* feat: update permission for tips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants