Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/link tag #40

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Feature/link tag #40

wants to merge 7 commits into from

Conversation

Fooooooooooox
Copy link
Collaborator

Description

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • I have updated the abi and docs
  • I tested locally to make sure this feature/fix works

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 6, 2023
View reviewed changes
contracts/storage/LinklistStorage.sol Outdated
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set))
internal _linkedCharacterLinkTags;
// linklistId => linkKey => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set)) internal _linkedERC721Tags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedERC721Tags (contracts/storage/LinklistStorage.sol#57) is not in mixedCase
contracts/storage/LinklistStorage.sol Outdated
// linklistId => linkKey => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set)) internal _linkedERC721Tags;
// linklistId => address => tags
mapping(uint256 => mapping(address => EnumerableSet.Bytes32Set)) internal _linkedAdressTags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedAdressTags (contracts/storage/LinklistStorage.sol#59) is not in mixedCase
contracts/libraries/Constants.sol Outdated
Comment on lines 31 to 32
bytes32 public constant NoteLinkTag =
0x4c696e6b4e6f7465546167000000000000000000000000000000000000000000;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Constant Constants.NoteLinkTag (contracts/libraries/Constants.sol#31-32) is not in UPPER_CASE_WITH_UNDERSCORES
contracts/libraries/Constants.sol Outdated
Comment on lines 34 to 35
bytes32 public constant UriLinkTag =
0x4e6f74654c696e6b546167000000000000000000000000000000000000000000;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Constant Constants.UriLinkTag (contracts/libraries/Constants.sol#34-35) is not in UPPER_CASE_WITH_UNDERSCORES
contracts/storage/LinklistStorage.sol Outdated
// linklistId => address => tags
mapping(uint256 => mapping(address => EnumerableSet.Bytes32Set)) internal _linkedAdressTags;
// linklistId => address => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set)) internal _linkedUriTags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedUriTags (contracts/storage/LinklistStorage.sol#61) is not in mixedCase
contracts/storage/LinklistStorage.sol Outdated
// linklistId => characterId => tags
mapping(uint256 => mapping(uint256 => EnumerableSet.Bytes32Set)) internal _linkedCharacterTags;
// linklistId => linkKey => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set)) internal _linkedNoteTags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedNoteTags (contracts/storage/LinklistStorage.sol#52) is not in mixedCase
contracts/storage/LinklistStorage.sol Outdated
Comment on lines 54 to 55
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set))
internal _linkedCharacterLinkTags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedCharacterLinkTags (contracts/storage/LinklistStorage.sol#54-55) is not in mixedCase
contracts/storage/LinklistStorage.sol Outdated
mapping(uint256 => uint256) internal _currentTakeOver; // this slot is not used
mapping(uint256 => string) internal _uris; // tokenId => tokenURI
mapping(uint256 => string) internal _uris; // linklistId => tokenURI

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._uris (contracts/storage/LinklistStorage.sol#39) is not in mixedCase
contracts/storage/LinklistStorage.sol Outdated

// linklist tags
// linklistId => characterId => tags
mapping(uint256 => mapping(uint256 => EnumerableSet.Bytes32Set)) internal _linkedCharacterTags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedCharacterTags (contracts/storage/LinklistStorage.sol#50) is not in mixedCase
contracts/storage/LinklistStorage.sol Outdated
// linklistId => address => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set)) internal _linkedUriTags;
// linklistId => linklistId => tags
mapping(uint256 => mapping(uint256 => EnumerableSet.Bytes32Set)) internal _linkedLinklistTags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedLinklistTags (contracts/storage/LinklistStorage.sol#63) is not in mixedCase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Fooooooooooox