Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use next-intl #1026

Merged
merged 24 commits into from
Nov 27, 2023
Merged

feat: use next-intl #1026

merged 24 commits into from
Nov 27, 2023

Conversation

DIYgod
Copy link
Member

@DIYgod DIYgod commented Oct 21, 2023

WHAT

🤖 Generated by Copilot at 1a4ca3a

This pull request adds internationalization (i18n) support to the app using next-intl. It replaces the custom i18n module with the next-intl library, which allows the app to dynamically load and display messages for different languages and locales. It also adds next-intl middleware to the app, which sets the locale and messages based on the request headers or cookies. It updates the HomeFeed and TopicPage components to use the useTranslations hook from next-intl and fixes a punctuation error in a tooltip message. It adds four new files under src/messages that contain the translated messages for English, Japanese, Simplified Chinese, and Traditional Chinese.

🤖 Generated by Copilot at 1a4ca3a

To support many languages with ease
We added next-intl as a new dependency
It sets the locale and messages for each request
And lets us use useTranslations in the context
Now our app is more friendly and diverse

WHY

HOW

🤖 Generated by Copilot at 1a4ca3a

  • Add next-intl as a dependency for internationalization (link)
  • Replace custom i18n module with next-intl hook in components (link, link, link, link, link)
  • Wrap app with NextIntlClientProvider component and import messages dynamically in src/app/layout.tsx (link, link, link, link)
  • Add translated messages for English, Japanese, Simplified Chinese, and Traditional Chinese in src/messages folder (link, link, link, link)
  • Create and configure custom middleware for next-intl in src/middleware.ts (link, link)
  • Export getRequestConfig function from next-intl/server in src/i18n.ts (link)
  • Fix punctuation in tooltip label message in HomeFeed component (link)

CLAIM REWARDS

For first-time contributors, please leave your xLog address and Discord ID below to claim your rewards.

@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
xlog ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 5:21pm

@github-actions
Copy link

github-actions bot commented Oct 21, 2023

📦 Next.js Bundle Analysis for xlog

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 87.98 KB (🟢 -187 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/_error 231 B 88.2 KB 25.20% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@DIYgod DIYgod merged commit 91aa185 into dev Nov 27, 2023
2 checks passed
@DIYgod DIYgod deleted the feature/next-intl branch November 27, 2023 17:34
@yjl9903 yjl9903 mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant