Fix wait of conditional variable to prevent spurious wakeup

CrowCpp · Jul 19, 2024 · fed82a3 · fed82a3
1 parent c63e977
commit fed82a3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/crow/app.h b/include/crow/app.h
@@ -691,7 +691,7 @@ namespace crow
         {
             {
                 std::unique_lock<std::mutex> lock(start_mutex_);
-                if (!server_started_)
+                while (!server_started_)
                     cv_started_.wait(lock);
             }
             if (server_)

diff --git a/include/crow/http_server.h b/include/crow/http_server.h
@@ -196,7 +196,7 @@ namespace crow // NOTE: Already documented in "crow/app.h"
         void wait_for_start()
         {
             std::unique_lock<std::mutex> lock(start_mutex_);
-            if (!server_started_)
+            while (!server_started_)
                 cv_started_.wait(lock);
         }