Add type information #143
Open
Add type information #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this? |
CrowdHailer
reviewed
Apr 1, 2020
lib/ace/http2/frame.ex
Outdated
| @@ -68,8 +64,8 @@ defmodule Ace.HTTP2.Frame do | |||
| {:error, {:unknown_frame_type, type}} -> | |||
| {:ok, {{:unknown_frame_type, type}, unprocessed}} | |||
|
|
|||
| {:error, reason} -> | |||
| {:error, reason} | |||
| {:error, reason} -> | |||
|
This is good. Would be good to be able to Run dialyzer against it in travis |
|
@varnerac can you merge the latest master into this branch. Then have a look if dialyzer passes. https://travis-ci.org/github/CrowdHailer/Ace/pull_requests I see a few errors on master but wonder if the improved type information on here will clear them up. |
|
Will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type all the things. Minor refactors.