Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AP-29] Fix duplicate JavaScript loading #165

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

jbirdjavi
Copy link
Contributor

...and security gem updates.

See https://jira.cru.org/browse/AP-29

The ActiveAdmin JS code was getting loaded twice, which was causing two form fields to be added with every click.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (37082f1) to head (7f6a4f4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          28       28           
  Lines         483      483           
=======================================
  Hits          465      465           
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

I see you added the "On Staging" label, I'll get this merged to the staging branch!

@jbirdjavi jbirdjavi merged commit ef91634 into master Sep 20, 2024
4 checks passed
@jbirdjavi jbirdjavi deleted the AP-29_fix_duplicate_add branch September 20, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants