Campus question tests

CruGlobal · Nov 9, 2023 · 3fd15e2 · 3fd15e2
1 parent 5c78bdc
commit 3fd15e2
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 6 deletions.
diff --git a/app/scripts/directives/blocks.js b/app/scripts/directives/blocks.js
@@ -252,7 +252,6 @@ angular
             });
         };
         if ($scope.answer.value) {
-          $scope.searchingCampuses = true;
           $scope.searchCampuses($scope.answer.value).then((data) => {
             if (!data.length) {
               $scope.answer.value = '';

diff --git a/app/views/blocks/campusQuestion.html b/app/views/blocks/campusQuestion.html
@@ -3,6 +3,7 @@
     type="text"
     ng-model="answer.value"
     placeholder=""
+    name="campus"
     autocomplete="off"
     aria-autocomplete="none"
     class="form-control"

diff --git a/test/spec/directives/block.spec.js b/test/spec/directives/block.spec.js
@@ -159,16 +159,18 @@ describe('Directive: blocks', () => {
   });
 
   describe('campusQuestion', () => {
-    let $compile, $rootScope, $scope;
+    let $compile, $rootScope, $scope, $httpBackend;
     beforeEach(inject((
       _$compile_,
       _$rootScope_,
       _$timeout_,
       $templateCache,
       testData,
+      _$httpBackend_,
     ) => {
       $compile = _$compile_;
       $rootScope = _$rootScope_;
+      $httpBackend = _$httpBackend_;
 
       $scope = $rootScope.$new();
       $templateCache.put('views/blocks/campusQuestion.html', '');
@@ -201,13 +203,18 @@ describe('Directive: blocks', () => {
     });
 
     it('checks the campus database if a answer is present on page load', () => {
-      expect($scope.searchingCampuses).toBe(undefined);
+      $httpBackend
+        .whenGET('campuses/SFSU?includeInternational=true&limit=15')
+        .respond(() => [200, []]);
 
       $scope.answer = { value: 'SFSU' };
       $compile('<campus-question></campus-question>')($scope);
-      $scope.$digest();
 
-      expect($scope.searchingCampuses).toBe(true);
+      $httpBackend.flush();
+      $httpBackend.verifyNoOutstandingExpectation();
+      $httpBackend.verifyNoOutstandingRequest();
+
+      expect($scope.answer.value).toBe('');
     });
   });
 

diff --git a/test/spec/services/validateRegistrant.spec.js b/test/spec/services/validateRegistrant.spec.js
@@ -91,7 +91,7 @@ describe('Service: validateRegistrant', function () {
     expect(validateRegistrant.validate(conference, registrant).length).toBe(1);
   });
 
-  it('empty campus name should not be valid', function () {
+  it('marks an empty campus name as invalid', function () {
     const conference = angular.copy(testData.conference);
     conference.registrationPages[1].blocks[13].required = true;
 
@@ -101,6 +101,16 @@ describe('Service: validateRegistrant', function () {
     expect(validateRegistrant.validate(conference, registrant).length).toBe(1);
   });
 
+  it('doesnt mark as invalid a campusQuestion field that is filled in', function () {
+    const conference = angular.copy(testData.conference);
+    conference.registrationPages[1].blocks[13].required = true;
+
+    const registrant = angular.copy(testData.registration.registrants[0]);
+    registrant.answers[12].value = 'San Francisco State University';
+
+    expect(validateRegistrant.validate(conference, registrant).length).toBe(0);
+  });
+
   it('empty address fields should not be valid when missing address1, state, zip or city', function () {
     var conference = angular.copy(testData.conference);
     conference.registrationPages[1].blocks[7].required = true;