Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HS-1245681] Hiding child question blocks #859

Merged
merged 5 commits into from
Oct 22, 2024
Merged

[HS-1245681] Hiding child question blocks #859

merged 5 commits into from
Oct 22, 2024

Conversation

caleballdrin
Copy link
Contributor

https://secure.helpscout.net/conversation/2738597988/1245681?folderId=7669074

Hide questions if it has a rule and the question that the rule is based on is hidden.

@caleballdrin caleballdrin self-assigned this Oct 22, 2024
@caleballdrin caleballdrin requested a review from canac October 22, 2024 18:07
@caleballdrin caleballdrin added the On Staging Will be merged to the staging branch by Github Actions label Oct 22, 2024
canac
canac reviewed Oct 22, 2024
View reviewed changes
app/scripts/services/validateRegistrant.js Outdated Show resolved Hide resolved
app/scripts/services/validateRegistrant.js Outdated Show resolved Hide resolved
app/scripts/services/validateRegistrant.js Show resolved Hide resolved
test/spec/directives/block.spec.js Outdated Show resolved Hide resolved
test/spec/services/validateRegistrant.spec.js Show resolved Hide resolved
test/spec/testData.spec.js Show resolved Hide resolved
@wrandall22
Copy link
Contributor

For PRs that are from HS tickets, I prefer we use the HS-123456 instead of [No-Jira] as a prefix in the title. This is more explanatory.

@caleballdrin caleballdrin changed the title [No-Jira] - Clearing-fields [HS-1245681] Hiding child question blocks Oct 22, 2024
@caleballdrin caleballdrin requested a review from canac October 22, 2024 20:39
canac
canac approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it! 🚀

@caleballdrin caleballdrin merged commit d54edba into master Oct 22, 2024
14 checks passed
@caleballdrin caleballdrin deleted the clearing-fields branch October 22, 2024 21:06
@canac canac mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees

@caleballdrin caleballdrin

Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caleballdrin @wrandall22 @canac