Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HS-1241612] Prevent conference names from containing special characters #860

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 22, 2024

Description

  • Prevent users from creating conferences with names containing ampersand or double quotes. Apparently, those special characters are causing issues on the server.
  • Also prevent users from editing conferences to contain an ampersand or double quote. If they have an existing conference with an ampersand or a double quote, they will change the name before they can edit any other conference details. My understanding is that that is desirable.
  • Also prevent users from editing conference abbreviations to contain an ampersand or double quote.

Testing

  • From the admin dashboard, click "Create New Event"
    • Validate that there are errors when the event name is empty (after focusing the name input and then moving focus) and the form cannot be submitted.
    • Validate that there are errors when the event name contains an ampersand (&) and the form cannot be submitted.
    • Validate that there are errors when the event name contains a double quote (") and the form cannot be submitted.
    • Validate that there are no errors when the event name is valid and the form can be submitted.
  • From the admin dashboard, click on an event, then go to Details and change the Event Name.
    • Validate that there are errors when the event name contains an ampersand (&).
    • Validate that there are errors when the event name contains a double quote (").
    • Validate that there are no errors when the event name is valid and that the event name is updated.
  • From the admin dashboard, click on an event, then go to Details and change the Event Abbreviation.
    • Validate that there are errors when the event abbreviation contains an ampersand (&).
    • Validate that there are errors when the event abbreviation contains a double quote (").
    • Validate that there are no errors when the event abbreviation is valid and that the event abbreviation is updated.

https://secure.helpscout.net/conversation/2731356723/1241612/

cc @hlbraddock

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Oct 22, 2024
@canac canac requested a review from dr-bizz October 22, 2024 20:55
@canac canac self-assigned this Oct 22, 2024
@canac canac force-pushed the hs-1241612-validate-name branch from 5316da0 to 48a5ca2 Compare October 23, 2024 14:33
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well. Thank you or fixing this. I left a few comments, but I will approve so not to block you.

app/scripts/controllers/eventDashboard.js Show resolved Hide resolved
test/spec/controllers/eventDetails.spec.js Show resolved Hide resolved
@canac canac merged commit c70f987 into master Oct 28, 2024
14 checks passed
@canac canac deleted the hs-1241612-validate-name branch October 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants