Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVENT-849] Always show promo code box #861

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 29, 2024

Users are requesting that the promo code box is always visible instead of requiring the user to click the "Add Promotion Code" link first.

HelpScout ticket: https://secure.helpscout.net/conversation/2718660687/1234291/

EVENT-849

@canac canac requested a review from dr-bizz October 29, 2024 20:48
@canac canac self-assigned this Oct 29, 2024
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! Is there a way to test this? I tried on my local, but I don't have an event with payment details filled out, and I don't know the test Merchant Account ID to be able to test this.

@dr-bizz dr-bizz self-requested a review October 30, 2024 17:20
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@canac canac merged commit 9f67495 into master Oct 31, 2024
13 checks passed
@canac canac deleted the 849-always-show-promo-code branch October 31, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants