HS-1245681 Fix Hidden Question Validation #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleballdrin
added
the
On Staging
canac
reviewed
Nov 8, 2024
| @@ -287,6 +287,7 @@ angular | |||
| block, | |||
| registrant, | |||
| ruleTypeConstants.SHOW_QUESTION, | |||
| conference, | |||
There was a problem hiding this comment.
Should we add this to this.checkboxDisable also?
There was a problem hiding this comment.
That will be done in a follow-up PR
caleballdrin
force-pushed
the
fix-hidden-q-validation
branch
from
7aa6641 to
93cda90
Compare
canac
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://secure.helpscout.net/conversation/2738597988/1245681?folderId=7669074
-In the
validate()function we need to callblockVisibleRuleCheck()withconferenceso it can accurately check if the question is hidden.-Add tests