family life gift card app #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
able to generate now and proper auth on the admin for issuances - no editing issuance after gift cards are created
various other fixes and progress towards issuing and displaying gift cards
store gift card type on each gift card
we don't use sidekiq but it's already set up in terraform and could be used in the future, so it's good to have
knutsenm
requested changes
Dec 11, 2024
| end | ||
|
|
||
| # largest number in certificates represented in x's in format, for all certificates matching format | ||
| def largest_existing_number_in_certificate |
There was a problem hiding this comment.
Will definitely needs tests for this ;-)
…-cards into rails_7_rebase
fix typo Co-authored-by: Mark Knutsen <[email protected]>
…-cards into rails_7_rebase
don't filter out certificate column in gift cards
…-cards into rails_7_rebase
knutsenm
requested changes
Dec 12, 2024
Co-authored-by: Mark Knutsen <[email protected]>
…-cards into rails_7_rebase
knutsenm
requested changes
Dec 17, 2024
| gc.registrations_available = row["numberRegistrations"].to_i | ||
| gc.certificate_value = row["certificateValue"].to_d | ||
| gc.gl_code = row["glCode"] | ||
| gc.created_at = DateTime.parse(row["addDate"]) if row["created_at"] |
There was a problem hiding this comment.
Suggested change
| gc.created_at = DateTime.parse(row["addDate"]) if row["created_at"] | |
| gc.created_at = DateTime.parse(row["addDate"]) if row["addDate"] |
...perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.