Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post upgrade go live #1071

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Post upgrade go live #1071

wants to merge 2 commits into from

Conversation

wrandall22
Copy link
Contributor

Now that EP upgrade and AEM cloud have gone live, we can remove parallel environments.

@wrandall22 wrandall22 requested a review from canac October 30, 2023 15:56
@wrandall22 wrandall22 force-pushed the post-upgrade-go-live branch from 93eab4a to a05902a Compare October 30, 2023 15:56
canac
canac requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a few more to remove at

give-web/src/common/services/api/cart.service.js

Line 44 in a05902a

if (!['give.cru.org', 'give-stage2.cru.org', 'give-stage2-next.cru.org', 'give-stage-cloud.cru.org', 'give-prod-cloud.cru.org'].includes(this.$location.host())) {

productViewDetailsEvent and ministriesList tests also use give-stage-cloud.cru.org URLs in their mocks, so it might be good to change those too to avoid confusion.

@wrandall22 wrandall22 force-pushed the post-upgrade-go-live branch from a05902a to 0797206 Compare October 30, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrandall22 @canac