-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HS-1063275] Fix long opportunity names #1078
Conversation
@canac Can I see this in action somewhere? I want to check the responsiveness. |
@j2trumpet https://give-stage2.cru.org/search-results.html?type=featured You'll have to manually change the text of the "Testing UAT Campaign Page Population" element in DevTools so that it's longer. Here's the production page too: https://give.cru.org/search-results.html?type=featured |
Seems like we should push back on them creating such long names in the first place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would get rid of the margin-right: $gutter*.5;
on line 291, add align-items: center
and column-gap: $gutter*.5
to .is-row
, and remove the "clearfix" class from the HTML output on every .is-row
.
@canac My suggested changes will vertically center the three pieces of content with each other and add space between the text and the buttons. We could have just added margin like the image had, but that's not the flex way to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Staging looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Should we go live with this in the code freeze, or wait until Jan?
@dr-bizz I'm going to assume after January. If they have issues in the meantime, they can shorten their campaign titles as a workaround. |
Fix long opportunity names displaying under the thumbnail image by switching from floating to flexbox.
Before:
After:
https://secure.helpscout.net/conversation/2443333491/1063275?folderId=7296729