Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HS-1063275] Fix long opportunity names #1078

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

canac
Copy link
Contributor

@canac canac commented Dec 5, 2023

Fix long opportunity names displaying under the thumbnail image by switching from floating to flexbox.

Before:
Screenshot 2023-12-05 at 11 16 52 AM

After:
Screenshot 2023-12-05 at 11 16 36 AM

https://secure.helpscout.net/conversation/2443333491/1063275?folderId=7296729

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Dec 5, 2023
@j2trumpet
Copy link
Contributor

@canac Can I see this in action somewhere? I want to check the responsiveness.

@canac
Copy link
Contributor Author

canac commented Dec 5, 2023

@j2trumpet https://give-stage2.cru.org/search-results.html?type=featured You'll have to manually change the text of the "Testing UAT Campaign Page Population" element in DevTools so that it's longer.

Here's the production page too: https://give.cru.org/search-results.html?type=featured

@wrandall22
Copy link
Contributor

Seems like we should push back on them creating such long names in the first place.

Copy link
Contributor

@j2trumpet j2trumpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would get rid of the margin-right: $gutter*.5; on line 291, add align-items: center and column-gap: $gutter*.5 to .is-row, and remove the "clearfix" class from the HTML output on every .is-row.

@j2trumpet
Copy link
Contributor

@canac My suggested changes will vertically center the three pieces of content with each other and add space between the text and the buttons. We could have just added margin like the image had, but that's not the flex way to do it.

Screen Shot 2023-12-05 at 10 19 28 AM

Copy link
Contributor

@j2trumpet j2trumpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging looks good to me!

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Should we go live with this in the code freeze, or wait until Jan?

@canac
Copy link
Contributor Author

canac commented Dec 7, 2023

@dr-bizz I'm going to assume after January. If they have issues in the meantime, they can shorten their campaign titles as a workaround.

@canac canac merged commit d0d3f02 into master Jan 9, 2024
4 checks passed
@canac canac deleted the hs-1063275-opportunities-wrap branch January 9, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants