Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP-2471] Customize payment method loading error #1084

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

canac
Copy link
Contributor

@canac canac commented Dec 20, 2023

Show a custom error message for 500 errors when loading payment methods until the underlying issue is fixed on the server.

https://jira.cru.org/browse/EP-2471

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Dec 20, 2023
@canac canac requested review from wrandall22 and dr-bizz December 20, 2023 18:29
Copy link
Contributor

@wrandall22 wrandall22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a test, though only if it is easy. This code will go away when the underlying bug is fixed.

@canac
Copy link
Contributor Author

canac commented Dec 20, 2023

@wrandall22 Do we want to merge this immediately despite the code freeze?

@wrandall22
Copy link
Contributor

Yes, but we need to be prepared to rollback if needed.

@canac canac merged commit 73af65d into master Dec 20, 2023
5 checks passed
@canac canac deleted the 2471-loading-payment-error branch December 20, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants