EP-2488 - Fix payment link #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrandall22
added
the
On Staging
|
Doesn't appear to be deploying to stage properly |
canac
approved these changes
Mar 22, 2024
|
When it properly deploys (hence #1097), when you go to the recipient view historical donations and drill into a recipient you should see the payment details filled out. |
dr-bizz
approved these changes
Mar 22, 2024
|
Got the deploy to stage done if you want to look, it looks good to me there. |
wrandall22
force-pushed
the
EP-2488-fix-payment-link
branch
from
89d9bb3 to
a5ad715
Compare
|
Yep, I see the payment info in staging now. Great work with the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrated to EP 8.1, the link got renamed from
payment-method-linktopayment-instrument-link, but that change did not get updated on the front-end. This only fixes the recipient view of historical donations, not the monthly view. Either monthly will have to be fixed on the back-end, or #1095 will fix it.