-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP-2517 Branded Checkout Improvements #1117
Open
caleballdrin
wants to merge
16
commits into
master
Choose a base branch
from
EP-2517-branded-checkout-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+737
−434
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5818f43
Change to dev.v2.js for local development
caleballdrin 874f3fd
Add use-v3 config variable
caleballdrin ac2d5d9
EP-2519 - Add styles for reordering gift selection on useV3. (#1118)
wjames111 41840af
EP-2525 - Hide unnecessary fields (#1120)
wjames111 4ec9576
Reorders gift selection to frequency/dates/amount. (#1127)
wjames111 1522b6a
Add submitOrder() service
caleballdrin 70f2559
Add submitOrderInternal and helper functions to branded checkout step 1
caleballdrin 315bd48
Remove submitOrderInternal() from step 3 and use orderService.submitO…
caleballdrin e3818f6
Add recaptcha button and loading if using V3
caleballdrin 4408c96
Remove componentInstance from Recaptcha and use apply() to make Angul…
caleballdrin 545412e
Move variables to cartEvents.js to avoid circular dependency
caleballdrin 1b24d26
Move checkout error messages to a new component
caleballdrin 346ee7b
Merge remote-tracking branch 'origin/EP-2517-branded-checkout-improve…
caleballdrin 405bd6e
Merge pull request #1119 from CruGlobal/EP-2518-remove-confirmation-step
caleballdrin d964703
EP-2560 (#1129)
wjames111 806d875
EP-2560-QA-1 (#1131)
wjames111 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
<checkout-error-messages | ||
needinfo-errors="$ctrl.needinfoErrors" | ||
submission-error="$ctrl.submissionError" | ||
submission-error-status="$ctrl.submissionErrorStatus"> | ||
</checkout-error-messages> | ||
<div class="panel"> | ||
<div class="panel-body loading-overlay-parent"> | ||
<loading ng-if="$ctrl.loadingProductConfig"> | ||
|
@@ -11,7 +16,9 @@ | |
submitted="$ctrl.submitted" | ||
on-state-change="$ctrl.onGiftConfigStateChange(state)" | ||
disable-session-restart="true" | ||
ng-if="!$ctrl.loadingProductConfig && !$ctrl.errorLoadingProductConfig"> | ||
ng-if="!$ctrl.loadingProductConfig && !$ctrl.errorLoadingProductConfig" | ||
use-v3="$ctrl.useV3" | ||
> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's put this |
||
</product-config-form> | ||
<div ng-if="$ctrl.errorLoadingProductConfig" class="alert alert-danger" role="alert"> | ||
<p translate='LOADING_ERROR' translate-values="{loadData: '$ctrl.loadData()'}" translate-compile></p> | ||
|
@@ -21,13 +28,14 @@ | |
<div ng-if="!$ctrl.loadingProductConfig && !$ctrl.errorLoadingProductConfig"> | ||
<div class="panel"> | ||
<div class="panel-body"> | ||
<h3 class="panel-name" translate>{{'YOUR_INFORMATION'}}</h3> | ||
<h3 ng-if="$ctrl.useV3 !== 'true'" class="panel-name" translate>{{'YOUR_INFORMATION'}}</h3> | ||
<contact-info | ||
submitted="$ctrl.submitted" | ||
on-submit="$ctrl.onContactInfoSubmit(success)" | ||
donor-details="$ctrl.donorDetails" | ||
radio-station-api-url="$ctrl.radioStationApiUrl" | ||
radio-station-radius="$ctrl.radioStationRadius"> | ||
radio-station-radius="$ctrl.radioStationRadius" | ||
use-v3="$ctrl.useV3"> | ||
</contact-info> | ||
</div> | ||
</div> | ||
|
@@ -46,10 +54,26 @@ <h3 class="panel-name" translate>{{'PAYMENT'}}</h3> | |
</div> | ||
<div class="panel"> | ||
<div class="panel-body text-right"> | ||
<button class="btn btn-primary" | ||
<div class="checkout-cta pull-right" ng-if="$ctrl.useV3 === 'true'"> | ||
<recaptcha-wrapper | ||
action="'branded_submit'" | ||
on-success="$ctrl.submit" | ||
on-failure="$ctrl.handleRecaptchaFailure" | ||
component-instance="$ctrl" | ||
button-id="'submitOrderButton'" | ||
button-type="'submit'" | ||
button-classes="'btn btn-primary btn-lg btn-block'" | ||
button-disabled="$ctrl.errorLoadingProductConfig || !$ctrl.canSubmitOrder()" | ||
button-label="'SUBMIT_GIFT'"></recaptcha-wrapper> | ||
</div> | ||
|
||
<button ng-if="$ctrl.useV3 !== 'true'" class="btn btn-primary" | ||
ng-click="$ctrl.submit()" | ||
ng-disabled="$ctrl.errorLoadingProductConfig" | ||
translate>{{'CONTINUE'}}</button> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
<loading type="fixed" ng-if="$ctrl.loadingAndSubmitting"> | ||
<translate>{{'SUBMITTING_GIFT'}}</translate> | ||
</loading> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/app/checkout/checkout-error-messages/checkout-error-messages.component.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import angular from 'angular' | ||
|
||
import template from './checkout-error-messages.tpl.html' | ||
|
||
const componentName = 'checkoutErrorMessages' | ||
|
||
class CheckoutErrorMessagesController {} | ||
|
||
export default angular | ||
.module(componentName, []) | ||
.component(componentName, { | ||
controller: CheckoutErrorMessagesController, | ||
templateUrl: template, | ||
bindings: { | ||
needinfoErrors: '<', | ||
submissionError: '<', | ||
submissionErrorStatus: '<' | ||
} | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to change this back before we merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there mention of JSON config file for these options or did I make that up? Are we just using the use-v3 flag for everything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no config file, we use this flag for everything.