EP-2519 - Add styles for reordering gift selection on useV3. #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjames111
commented
Nov 20, 2024
wjames111
commented
- move the frequency choice above the amount choice so that the user will pick it first. This should be conditional based on a new configuration option which defaults to the current version.
- Jira ticket 2517
wjames111
changed the title
dr-bizz
reviewed
Nov 26, 2024
There was a problem hiding this comment.
The code looks great!
As a personal preference, I think we should remove the padding around the amount if it is no longer the first option. - I also don't know why the padding is there in the first place.
Can we also push this to staging so we can test it there?
|
Ah, since this is going into the |
|
We won't be able to test in stage until the new config is available in WP or AEM. |
wjames111
merged commit ac2d5d9
into
EP-2517-branded-checkout-improvements
1 check passed
rguinee
pushed a commit
that referenced
this pull request
Dec 16, 2024
Add styles for reordering gift selection with useV3 flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.