EP-2525 - Hide unnecessary fields #1120
Conversation
wjames111
changed the base branch from
EP-2519
to
EP-2517-branded-checkout-improvements
src/app/productConfig/productConfigModal/productConfig.modal.component.js
Outdated
Show resolved
Hide resolved
| @@ -214,7 +214,7 @@ <h4 class="panel-title border-bottom-small mt0 pt-" translate> | |||
| </div><!-- // panel --> | |||
| </div> | |||
| </div> | |||
| <div class="panel panel-default give-modal-panel"> | |||
| <div ng-if="$ctrl.useV3 !== 'true'" class="panel panel-default give-modal-panel"> | |||
There was a problem hiding this comment.
One concern I realize I have with this is our datadog tests. These rely on the special instructions in order to work. We'll need to make sure that our tests are pointing at a v2 branded checkout.
src/app/productConfig/productConfigModal/productConfig.modal.tpl.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We need to ensure the country is present on this form.
When I enter my British address, I'm unable to change the country, which means the input fields doesn't change to the International input fields. This means it requires me to select a US State, which is wrong.
69 Drayton Place, (Address)
Irthlingborough, (city)
Northamptonshire, (County)
NN9 5TD, (post code)
England (country)
|
This feedback needs to go back to the stakeholders, and we need to come up with that 1. removes unnecessary fields without removing one users' needs and 2. allows the user to enter the field if they desire. |
wjames111
merged commit 41840af
into
EP-2517-branded-checkout-improvements
There is a desire to reduce friction by removing fields that are unnecessary for checkout to work properly. The new config option should hide/show all of these fields. Currently proposed fields:
-Additional your information header
Jira Ticket EP-2525