-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EP-2362] Deduplicate sign in modals #1132
Conversation
We need to look at the sign in link on AEM to see if we need to change it with this change. |
As I was reading your code, I see that we won't need to as you have kept the |
@dr-bizz I found some places in the designation account editor and session enforcer that explicitly open the |
modal = sessionModalService.open('register-account', { | ||
backdrop: 'static', | ||
keyboard: false | ||
}).result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should const modalType = find(enforced, { mode: EnforcerModes.donor })
this define if the register-account modal is minimal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you're asking. But now the register-account
modal now defaults to minimal mode (welcomeBack
is falsy), if that's what you mean.
937f374
to
376e5b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
2b36860
to
203c89c
Compare
Previously, the sign in modal could be opened from the session modal directly or from the register account modal inside of the session modal. The main difference was that the direct sign in modal didn't have the "Welcome back!" header/sidebar.
This PR removes the sign in modal from the session modal so that it will always be displayed inside of the register account modal. I added the
minimal
binding that when set to true hides the Welcome back header/sidebar.I also cleaned up the bindings of signInModal so that no longer directly changes the state of the parent modal.