Skip to content

Commit

Permalink
replace rememberRipple() with ripple()
Browse files Browse the repository at this point in the history
  • Loading branch information
frett committed Sep 5, 2024
1 parent 44f8515 commit 69601d8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion app/config/ktlint/baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<error line="40" column="9" source="compose:vm-injection-check" />
</file>
<file name="src/main/kotlin/org/cru/godtools/ui/languages/downloadable/DownloadableLanguagesLayout.kt">
<error line="59" column="5" source="compose:modifier-missing-check" />
<error line="58" column="5" source="compose:modifier-missing-check" />
</file>
<file name="src/main/kotlin/org/cru/godtools/ui/login/LoginLayout.kt">
<error line="51" column="5" source="compose:modifier-missing-check" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import androidx.compose.foundation.lazy.rememberLazyListState
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.ArrowBack
import androidx.compose.material.icons.filled.Close
import androidx.compose.material.ripple.rememberRipple
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.Icon
Expand All @@ -22,6 +21,7 @@ import androidx.compose.material3.ListItem
import androidx.compose.material3.Scaffold
import androidx.compose.material3.SearchBar
import androidx.compose.material3.Text
import androidx.compose.material3.ripple
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.collectAsState
Expand All @@ -36,7 +36,6 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.pluralStringResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import androidx.lifecycle.viewmodel.compose.viewModel
import kotlinx.coroutines.NonCancellable
Expand Down Expand Up @@ -152,7 +151,7 @@ private fun LanguageListItem(viewModel: LanguageViewModels.LanguageViewModel, mo
modifier = Modifier
.clickable(
interactionSource = remember { MutableInteractionSource() },
indication = rememberRipple(bounded = false, radius = Dp.Unspecified),
indication = ripple(bounded = false),
) {
when {
!language.isAdded -> scope.launch(NonCancellable) { viewModel.pin() }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ import androidx.compose.foundation.layout.height
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.Add
import androidx.compose.material.icons.filled.Remove
import androidx.compose.material.ripple.rememberRipple
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.Icon
import androidx.compose.material3.LocalTextStyle
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.ProvideTextStyle
import androidx.compose.material3.Text
import androidx.compose.material3.ripple
import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.runtime.derivedStateOf
Expand Down Expand Up @@ -174,7 +174,7 @@ private fun ToolDetailsAboutAccordionSection(
Icon(
if (expanded) Icons.Filled.Remove else Icons.Filled.Add,
contentDescription = null,
modifier = Modifier.indication(headerInteractions, rememberRipple(bounded = false, radius = 20.dp))
modifier = Modifier.indication(headerInteractions, ripple(bounded = false, radius = 20.dp))
)
}
AnimatedVisibility(visible = expanded) {
Expand Down

0 comments on commit 69601d8

Please sign in to comment.