Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup #3118

Merged
merged 6 commits into from
Sep 26, 2023
Merged

cleanup #3118

merged 6 commits into from
Sep 26, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Sep 25, 2023

  • use the model test constructor functions instead
  • remove several unused functions from BaseSyncTasks
  • remove unneeded with method from GodToolsSyncService
  • remove unnecessary @JvmSuppressWildcards annotation

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #3118 (3fe0fe4) into develop (5d2de43) will increase coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop    #3118      +/-   ##
===========================================
+ Coverage    31.42%   31.44%   +0.01%     
===========================================
  Files          422      422              
  Lines        10328    10323       -5     
  Branches      2289     2288       -1     
===========================================
  Hits          3246     3246              
+ Misses        6543     6538       -5     
  Partials       539      539              
Files Coverage Δ
...otlin/org/cru/godtools/sync/GodToolsSyncService.kt 65.30% <100.00%> (+1.30%) ⬆️
...kotlin/org/cru/godtools/sync/task/BaseSyncTasks.kt 100.00% <ø> (+80.00%) ⬆️
.../src/main/kotlin/org/cru/godtools/api/ApiModule.kt 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

They are rendered directly below the number they refer to
@frett frett merged commit 07396dd into develop Sep 26, 2023
@frett frett deleted the cleanup branch September 26, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant