Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2145 create a normalized_app_language #3131

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #3131 (430724f) into develop (6f86c3b) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3131   +/-   ##
========================================
  Coverage    31.58%   31.58%           
========================================
  Files          422      422           
  Lines        10357    10357           
  Branches      2289     2288    -1     
========================================
  Hits          3271     3271           
  Misses        6547     6547           
  Partials       539      539           
Files Coverage Δ
.../src/main/kotlin/org/cru/godtools/base/Settings.kt 46.55% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frett frett changed the title GT-2145 create a normalized_content_locale GT-2145 create a normalized_app_language Oct 4, 2023
@frett frett force-pushed the contentLanguageSelection branch from 15f8dee to 430724f Compare October 4, 2023 14:29
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="normalized_app_language">id</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "in"

Copy link
Contributor Author

@frett frett Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in is a legacy language tag for indonesian, with id being the correct language tag to use. But It doesn't actually matter if it's id or in because of how the locale object handles the Indonesian language.

Internally the locale object converts Indonesian to in due to old behavior and backwards compatibility. This conversion means that older versions of Android need a values-in directory, and newer versions prefer values-id. To ensure compatibility we just duplicate the correct values-id to the incorrect values-in

@frett frett requested a review from gyasistory October 5, 2023 20:56
@frett frett dismissed gyasistory’s stale review October 6, 2023 15:25

responded to comments

@frett frett merged commit 424e3b3 into develop Oct 6, 2023
12 checks passed
@frett frett deleted the contentLanguageSelection branch October 6, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants