Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some AccountManager properties #3154

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Cleanup some AccountManager properties #3154

merged 3 commits into from
Oct 12, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 12, 2023

  • nothing requires isAuthenticated or userId to be suspendable
  • make isAuthenticated and userId properties instead of methods
  • there is no need to make SessionInterceptor.userId() suspendable

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #3154 (f214c3f) into develop (2a6a4f3) will increase coverage by 0.03%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop    #3154      +/-   ##
===========================================
+ Coverage    32.29%   32.33%   +0.03%     
===========================================
  Files          427      427              
  Lines        10504    10504              
  Branches      2317     2318       +1     
===========================================
+ Hits          3392     3396       +4     
+ Misses        6555     6552       -3     
+ Partials       557      556       -1     
Files Coverage Δ
...tlin/org/cru/godtools/ui/drawer/DrawerViewModel.kt 80.00% <100.00%> (ø)
...g/cru/godtools/account/provider/AccountProvider.kt 0.00% <ø> (ø)
...ols/analytics/firebase/FirebaseAnalyticsService.kt 46.51% <100.00%> (ø)
...n/kotlin/org/cru/godtools/user/data/UserManager.kt 85.71% <100.00%> (ø)
.../kotlin/org/cru/godtools/ui/login/LoginActivity.kt 0.00% <0.00%> (ø)
...n/kotlin/org/cru/godtools/account/AccountModule.kt 0.00% <0.00%> (ø)
...count/provider/facebook/FacebookAccountProvider.kt 62.50% <50.00%> (ø)
...godtools/api/MobileContentApiSessionInterceptor.kt 0.00% <0.00%> (ø)
...kotlin/org/cru/godtools/sync/task/UserSyncTasks.kt 73.68% <50.00%> (ø)
...org/cru/godtools/account/GodToolsAccountManager.kt 70.37% <71.42%> (+14.81%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frett frett merged commit 044c825 into develop Oct 12, 2023
@frett frett deleted the accountManagerCleanup branch October 12, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant