Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2161 Adjust download logic for pinned languages #3156

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 12, 2023

  • download all tools for pinned languages
  • remove some duplciated logic for dispatching attachment downloads

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #3156 (057a6ed) into develop (044c825) will increase coverage by 11.30%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           develop    #3156       +/-   ##
============================================
+ Coverage    21.06%   32.37%   +11.30%     
============================================
  Files          427      427               
  Lines        10470    10511       +41     
  Branches      2292     2318       +26     
============================================
+ Hits          2206     3403     +1197     
+ Misses        7934     6552     -1382     
- Partials       330      556      +226     
Files Coverage Δ
...odtools/downloadmanager/GodToolsDownloadManager.kt 79.71% <100.00%> (+0.51%) ⬆️

... and 69 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frett frett merged commit 1f13db5 into develop Oct 12, 2023
@frett frett deleted the downloadAllToolsForPinnedLanguages branch October 12, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant