Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup #3180

Merged
merged 3 commits into from
Oct 20, 2023
Merged

cleanup #3180

merged 3 commits into from
Oct 20, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 19, 2023

  • make LanguageSettingEvents data objects
  • use kotlin-test for DownloadableLanguagesViewModelTest
  • make sure the languages MutableSharedFlow is subscribed to before starting tests

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #3180 (336b9c1) into develop (28b0d86) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3180   +/-   ##
========================================
  Coverage    32.70%   32.70%           
========================================
  Files          426      426           
  Lines        10507    10507           
  Branches      2302     2302           
========================================
  Hits          3436     3436           
  Misses        6514     6514           
  Partials       557      557           
Files Coverage Δ
...ru/godtools/ui/languages/LanguageSettingsLayout.kt 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frett frett merged commit ad87c49 into develop Oct 20, 2023
12 checks passed
@frett frett deleted the cleanup branch October 20, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant