Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2168 Performance Improvements for Language Filter #3193

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 26, 2023

  • resolve the appLanguage on a background thread
  • use remember to prevent a new flow from being created every time LocalAppLanguage.current is called
  • switch to a LazyColumn implementation of DropdownMenu for the languages filter

@frett frett force-pushed the languagesFilterPerformance branch from c875075 to 1a705d4 Compare October 26, 2023 22:05
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #3193 (1a705d4) into develop (29cf871) will increase coverage by 0.02%.
The diff coverage is 29.41%.

@@             Coverage Diff             @@
##           develop    #3193      +/-   ##
===========================================
+ Coverage    32.76%   32.78%   +0.02%     
===========================================
  Files          428      428              
  Lines        10515    10519       +4     
  Branches      2302     2304       +2     
===========================================
+ Hits          3445     3449       +4     
  Misses        6513     6513              
  Partials       557      557              
Files Coverage Δ
...c/main/kotlin/org/cru/godtools/base/AppLanguage.kt 25.00% <100.00%> (ø)
.../cru/godtools/ui/dashboard/tools/ToolsViewModel.kt 80.43% <80.00%> (-0.06%) ⬇️
...n/kotlin/org/cru/godtools/base/LocalAppLanguage.kt 0.00% <0.00%> (ø)
...org/cru/godtools/ui/dashboard/tools/ToolFilters.kt 49.45% <16.00%> (+1.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frett frett merged commit 61659ac into develop Oct 27, 2023
12 checks passed
@frett frett deleted the languagesFilterPerformance branch October 27, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant