Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2112 Present auth error messages to the user on login #3213

Merged
merged 11 commits into from
Nov 7, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Nov 3, 2023

No description provided.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #3213 (2adb2f9) into develop (494cd95) will increase coverage by 0.04%.
The diff coverage is 32.83%.

@@             Coverage Diff             @@
##           develop    #3213      +/-   ##
===========================================
+ Coverage    32.79%   32.83%   +0.04%     
===========================================
  Files          428      432       +4     
  Lines        10517    10606      +89     
  Branches      2303     2335      +32     
===========================================
+ Hits          3449     3483      +34     
- Misses        6511     6563      +52     
- Partials       557      560       +3     
Files Coverage Δ
.../kotlin/org/cru/godtools/ui/login/LoginActivity.kt 0.00% <ø> (ø)
...tlin/org/cru/godtools/ui/login/LoginLayoutEvent.kt 0.00% <0.00%> (ø)
...n/kotlin/org/cru/godtools/account/AccountModule.kt 0.00% <0.00%> (ø)
.../org/cru/godtools/account/compose/LoginLauncher.kt 0.00% <0.00%> (ø)
...dtools/account/provider/AuthenticationException.kt 85.71% <85.71%> (ø)
...ain/kotlin/org/cru/godtools/api/model/AuthToken.kt 54.54% <50.00%> (-1.02%) ⬇️
...n/kotlin/org/cru/godtools/account/LoginResponse.kt 0.00% <0.00%> (ø)
...ols/account/compose/LocalGodToolsAccountManager.kt 0.00% <0.00%> (ø)
...g/cru/godtools/account/provider/AccountProvider.kt 82.60% <82.60%> (+82.60%) ⬆️
...s/account/provider/google/GoogleAccountProvider.kt 48.71% <33.33%> (-3.01%) ⬇️
... and 3 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@frett frett force-pushed the accountCreationFeedback branch 2 times, most recently from 2759ee0 to 4b91af3 Compare November 3, 2023 18:05
@frett frett force-pushed the accountCreationFeedback branch from d3050f0 to 2adb2f9 Compare November 6, 2023 22:20
@frett frett requested a review from gyasistory November 6, 2023 22:46
@frett frett marked this pull request as ready for review November 6, 2023 22:47
@frett frett merged commit 3624911 into develop Nov 7, 2023
12 checks passed
@frett frett deleted the accountCreationFeedback branch November 7, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants