Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2314 use Circuit to render the Dashboard Home #3790

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Conversation

frett
Copy link
Contributor

@frett frett commented Nov 25, 2024

No description provided.

@frett frett marked this pull request as draft November 25, 2024 20:52
@frett frett force-pushed the circuitDashboardHome branch 2 times, most recently from efea518 to cc1ae2c Compare November 25, 2024 21:24
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 63 lines in your changes missing coverage. Please review.

Project coverage is 41.60%. Comparing base (1ed32f3) to head (b2ca1c8).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...rg/cru/godtools/ui/dashboard/home/HomePresenter.kt 32.85% 40 Missing and 7 partials ⚠️
...n/org/cru/godtools/ui/dashboard/home/HomeLayout.kt 69.69% 0 Missing and 10 partials ⚠️
...n/org/cru/godtools/ui/dashboard/DashboardLayout.kt 16.66% 5 Missing ⚠️
...n/org/cru/godtools/ui/dashboard/home/HomeScreen.kt 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3790      +/-   ##
===========================================
+ Coverage    41.13%   41.60%   +0.47%     
===========================================
  Files          449      450       +1     
  Lines        11856    11856              
  Branches      2605     2589      -16     
===========================================
+ Hits          4877     4933      +56     
+ Misses        6143     6080      -63     
- Partials       836      843       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frett frett force-pushed the circuitDashboardHome branch 5 times, most recently from 2fc2ef1 to afa4348 Compare November 26, 2024 17:58
@frett frett marked this pull request as ready for review November 26, 2024 18:07
@frett frett requested a review from gyasistory November 26, 2024 18:08
@frett frett force-pushed the circuitDashboardHome branch from 59ca90f to 6c9d9f8 Compare November 26, 2024 18:30
@frett frett force-pushed the circuitDashboardHome branch from 6c9d9f8 to b2ca1c8 Compare November 26, 2024 18:46
@frett frett merged commit 5d79459 into develop Nov 26, 2024
10 checks passed
@frett frett deleted the circuitDashboardHome branch November 26, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants