Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2314 only store language setting changes when launched from favorite tools #3827

Merged

Conversation

frett
Copy link
Contributor

@frett frett commented Dec 19, 2024

No description provided.

@frett frett force-pushed the GT-2314-Only-Save-Languages-when-launched-from-favorites branch from 7ef895a to 37db8ac Compare December 20, 2024 17:55
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 41.59%. Comparing base (578a82d) to head (37db8ac).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...main/kotlin/org/cru/godtools/util/ActivityUtils.kt 42.85% 4 Missing ⚠️
...l/ui/settings/SettingsBottomSheetDialogFragment.kt 0.00% 4 Missing ⚠️
...ls/base/tool/activity/MultiLanguageToolActivity.kt 0.00% 3 Missing ⚠️
...main/kotlin/org/cru/godtools/base/ui/Activities.kt 60.00% 2 Missing ⚠️
...rg/cru/godtools/ui/dashboard/home/HomePresenter.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3827      +/-   ##
===========================================
- Coverage    41.61%   41.59%   -0.02%     
===========================================
  Files          450      450              
  Lines        11915    11931      +16     
  Branches      2598     2599       +1     
===========================================
+ Hits          4958     4963       +5     
- Misses        6113     6124      +11     
  Partials       844      844              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frett frett merged commit b3e8958 into develop Dec 20, 2024
12 checks passed
@frett frett deleted the GT-2314-Only-Save-Languages-when-launched-from-favorites branch December 20, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant