GT-2323 observe the new force language name flag

[gyasistory]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 62.18905% with 76 lines in your changes missing coverage. Please review.

Project coverage is 40.56%. Comparing base (4141901) to head (b21026b).

Files	Patch %	Lines
...es/Dashboard/Presentation/Tool/ToolViewModel.swift	0.00%	17 Missing ⚠️
...tent/Views/Pages/MobileContentPagesViewModel.swift	0.00%	13 Missing ⚠️
...LanguageUseCase/LanguageDirectionDomainModel.swift	0.00%	6 Missing ⚠️
...lTraining/Presentation/ToolTrainingViewModel.swift	0.00%	5 Missing ⚠️
.../Views/Tool/Views/Card/ToolPageCardViewModel.swift	0.00%	5 Missing ⚠️
...cles/Presentation/Articles/ArticlesViewModel.swift	0.00%	3 Missing ⚠️
...ArticleCategories/ArticleCategoriesViewModel.swift	0.00%	2 Missing ⚠️
.../MobileContentRendererEventAnalyticsTracking.swift	0.00%	2 Missing ⚠️
.../Renderer/Renderer/MobileContentPageRenderer.swift	0.00%	2 Missing ⚠️
...age/MobileContentCardCollectionPageViewModel.swift	0.00%	2 Missing ⚠️
... and 16 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2173      +/-   ##
===========================================
- Coverage    40.75%   40.56%   -0.20%     
===========================================
  Files         1114     1115       +1     
  Lines        36272    36379     +107     
===========================================
- Hits         14784    14758      -26     
- Misses       21488    21621     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[levieggertcru]

Hey @rachaelblue these changes look right to me. I updated the tests to include the forceLanguageName (#2237).

[rachaelblue]

Hey @levieggertcru, how do you want to handle language direction on LanguageModel? Do you want to keep LanguageDirectionDomainModel? Seems like you were moving towards different models having their own version of the direction enum?

[levieggertcru]

Hey @rachaelblue yeah I'd say keep the LanguageDirectionDomainModel.

[levieggertcru]

I was starting to move the renderer towards pointing to the domain layer. The renderer is it's own beast though.

[rachaelblue]

Ok thanks @levieggertcru!

[levieggertcru]

Thanks @rachaelblue for making those extra updates!

[levieggertcru]

@rachaelblue going to wait to hear back from Jill and Aaron to see if they want this to go into the next release version 6.3.3 before approving for merger.

[frett]

@rachaelblue going to wait to hear back from Jill and Aaron to see if they want this to go into the next release version 6.3.3 before approving for merger.

The android version of this was already merged and will be in the version we push out with the new languages

[levieggertcru]

Thanks @frett!