Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge develop into master for new QA release #2194

Merged
merged 135 commits into from
Jul 10, 2024
Merged

Merge develop into master for new QA release #2194

merged 135 commits into from
Jul 10, 2024

Conversation

levieggertcru
Copy link
Collaborator

No description provided.

levieggertcru and others added 30 commits May 6, 2024 13:59
@levieggertcru
Remove publisher as argument in use case
8803430
@levieggertcru
Merge branch 'master' into feature/app-languages-feature-release-2.0
e937690
@levieggertcru
Remove LanguageSettingsRepository as we've moved to the app language …
b6c4174 
…feature
@levieggertcru
Merge pull request #2093 from CruGlobal/GT-remove-deprecated-language…
d534a56 
…-settings

GT Remove deprecated LanguageSettingsRepository
@levieggertcru
Merge pull request #2091 from CruGlobal/GT-remove-publisher-argument-…
6d74c6d 
…in-use-case

GT Remove publisher as argument in UseCase
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
81e4bb1
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
6e68ac0
@levieggertcru
Add sync invalidator to help manage when a new sync should take place…
6883237 
… by elapsed time
@levieggertcru
Add realm cache to app languages repository
44e9c75 
Add sync to app languages to sync every 15 minutes of elapsed time
Add interface to app language data model for simpler mapping between objects
Add fake api to app languages repository
@levieggertcru
Add prepend to observe changes which will trigger this when subscribed
1fc40c8
@levieggertcru
Update tests to include number of app languages
74d032b 
Add mock app languages sync for tests
@levieggertcru
Remove method to fetch realm cache and use publisher on repository to…
a7e382d 
… set the initial app language
@levieggertcru
Add extension to delete objects by primary keys with realm argument
81ecbfd 
Add method to delete language on RealmUserAppLanguageCache
@levieggertcru
Update MockAppLanguagesRepositorySync to take argument of app languages
91ece7f 
Add cancellables to tests that use sink
@levieggertcru
Merge pull request #2098 from CruGlobal/GT-2371-add-realm-cache-for-a…
ec8fd26 
…pp-languages

GT-2368-2371 Add realm cache for app languages and update behavior tests to include number of app languages
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
35c6016
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
971e922
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
c3fce60
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
10cf896
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
c7917bb
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
428a67b 
# Conflicts:
#	godtools/App/Share/Application/ApplicationLayout/ApplicationLayout.swift
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
eecc470
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
237c074
@levieggertcru
Merge branch 'develop' into feature/app-languages-feature-release-2.0
5023b69
@rachaelblue
use default language for category translation if tool doesn't support…
60156e1 
… app language
@rachaelblue
download default translation if app language translation not available
e74ead7
@rachaelblue
get numeral languageId rather than using locale/languageCode
4b0e6ff
@rachaelblue
actually commit languageId change
cb310ec
@rachaelblue
use default translation as fallback for for tool details
341a424
@rachaelblue
remove spaces
f888833
levieggertcru and others added 25 commits July 5, 2024 23:08
@levieggertcru @github-actions
[create-pull-request] automated change
acda2c5
@levieggertcru
Merge pull request #2184 from CruGlobal/latest-onesky-translations
bc9c412 
Latest OneSky Translations
@levieggertcru
Add run UITests to GodTools-Production scheme
268c5d4
@levieggertcru
Add run tests workflow
6700846
@levieggertcru
Try fastlane run tests with UI tests included
bf8e5aa
@levieggertcru
Add action pod install
9366e45 
Add workflow testflight
@levieggertcru
Update checkout location
79e8b3c
@levieggertcru
Move action to pod install directory
83732ee
@levieggertcru
Remove inputs and outputs
f2f305c
@levieggertcru
Add shell
1ab8fed
@levieggertcru
Remove archive for xcode logs
75999ac
@levieggertcru
Remove build
b9da3b0
@levieggertcru
Add code for archiving xcode logs
aa4164e
@levieggertcru
Remove UITests scheme
c18e62a
@levieggertcru
Add create-version workflow
6955938
@levieggertcru
Remove create-version workflow, will add in separate pull request
28e89d2
@levieggertcru
Change name run_tests
c2ee375
@levieggertcru
Merge pull request #2182 from CruGlobal/GT-2323-change-dependency-dir…
8d553db 
…ection

GT-2323 change dependency direction
@levieggertcru
Merge pull request #2185 from CruGlobal/GT-run-tests-workflow
9872905 
GT run tests workflow
@levieggertcru
Add create version workflow
d9476a8
@levieggertcru
Merge pull request #2189 from CruGlobal/GT-create-version
4d75ffe 
GT Add create version workflow
@levieggertcru
Update create version
ef9c175
@levieggertcru
Merge pull request #2191 from CruGlobal/GT-create-version
aef4c97 
Update create version
@levieggertcru
Increment version to 6.3.2
6b0d1f7
@levieggertcru
Merge pull request #2193 from CruGlobal/GT-increment-version-6.3.2
09d7892 
Increment version to 6.3.2
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.20190% with 293 lines in your changes missing coverage. Please review.

Project coverage is 30.10%. Comparing base (647e461) to head (09d7892).

Files Patch % Lines
...es/Dashboard/Presentation/Tool/ToolViewModel.swift 0.00% 42 Missing ⚠️
godtools/App/Flows/App/AppFlow.swift 14.58% 41 Missing ⚠️
...sRepository/Cache/RealmUserToolSettingsCache.swift 0.00% 19 Missing ⚠️
...pository/Sync/MockAppLanguagesRepositorySync.swift 47.05% 18 Missing ⚠️
...ettingsRepository/UserToolSettingsRepository.swift 0.00% 14 Missing ⚠️
...ata-DomainInterface/GetToolDetailsRepository.swift 0.00% 14 Missing ⚠️
...SettingsRepository/UserToolSettingsDataModel.swift 0.00% 12 Missing ⚠️
...ce/PersistUserToolLanguageSettingsRepository.swift 0.00% 11 Missing ⚠️
...yContainer/ToolSettingsDataLayerDependencies.swift 0.00% 11 Missing ⚠️
.../App/Flows/ToolNavigation/ToolNavigationFlow.swift 0.00% 11 Missing ⚠️
... and 34 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2194      +/-   ##
==========================================
+ Coverage   20.20%   30.10%   +9.90%     
==========================================
  Files        1065     1075      +10     
  Lines       34300    34550     +250     
==========================================
+ Hits         6931    10402    +3471     
+ Misses      27369    24148    -3221

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levieggertcru levieggertcru merged commit 065d16b into master Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyasistory gyasistory gyasistory approved these changes

@rachaelblue rachaelblue Awaiting requested review from rachaelblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@levieggertcru @gyasistory @rachaelblue