GT-2435 Fixes banner animation not showing when opening tool for first time #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hile offline and tool language already downloaded
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2257 +/- ##
===========================================
- Coverage 41.00% 40.99% -0.02%
===========================================
Files 1113 1113
Lines 36425 36427 +2
===========================================
- Hits 14935 14932 -3
- Misses 21490 21495 +5 ☔ View full report in Codecov by Sentry. |
levieggertcru
changed the title
rachaelblue
approved these changes
Sep 3, 2024
levieggertcru
deleted the
GT-2435-fix-about-animation-not-showing-when-offline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds about banner animation downloading to the tool downloader process. This will include banner animation downloads when choosing a language to download from the download languages list.
This change fixes an issue where opening a tool offline to tool details wouldn't display the banner animation.
Now when a language is chosen to download, such as English, it will include about banner animations and when an english tool is opened for the first time offline, it will display the about banner animation in tool details.