GT-2456 fix tract tools expanding into navbar #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levieggertcru
deleted the
GT-2456-fix-tract-tools-expanding-into-navbar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where opening tools in iOS 18 the tool content would be rendered behind the navigation bar and wasn't respecting the safe area. To trigger the bug you would have to open a tool that wasn't downloaded. For example, honor restored and power over fear tools.
The fix is to ensure the download tool modal is completely dismissed before navigating to a tool. Not sure if this is just something buggy in iOS 18 since this wasn't an issue in iOS 16 and iOS 17.