Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2489 state enum for language download icon #2386

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

rachaelblue
Copy link
Collaborator

No description provided.

@rachaelblue rachaelblue marked this pull request as ready for review January 8, 2025 01:34
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (e20b376) to head (d381110).
Report is 35 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2386      +/-   ##
===========================================
+ Coverage    95.92%   95.94%   +0.01%     
===========================================
  Files           62       62              
  Lines         5323     5323              
===========================================
+ Hits          5106     5107       +1     
+ Misses         217      216       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@levieggertcru levieggertcru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rachael I do like the single state for the icon and pushing some of that logic back into the DownloadableLanguageItemView.

@rachaelblue rachaelblue merged commit d9d451f into develop Jan 8, 2025
4 checks passed
@rachaelblue rachaelblue deleted the GT-2489-Single-State-for-LanguageDownloadIcon branch January 8, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants