Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2482 add fixed padding to mobile content renderer paragraph elements #2388

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

levieggertcru
Copy link
Collaborator

@levieggertcru levieggertcru commented Jan 8, 2025

This PR makes an adjustment to the mobile content renderer elements by applying a fixed top and bottom padding of 8 points to paragraph elements.

I removed the item spacing configuration on vertical stacks which applies spacing between direct child elements in the stack. Instead item spacing between child elements will remain at 0.

These changes are made to mimic Android.

The vertical stack item spacing change applied to the following elements and there may need to be some tweaks on these for this PR change:

  • Tract Page
  • Tract Card
  • Training Page
  • Content
  • Accordion Section
  • Card Collection Page Card
  • Lesson Page
  • Multi Select
  • Tab
  • Form
  • CYOA Intro Page
  • CYOA Categories Page

@levieggertcru levieggertcru marked this pull request as draft January 8, 2025 18:05
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (2789a2e) to head (a2060b7).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2388      +/-   ##
===========================================
+ Coverage    95.92%   95.94%   +0.01%     
===========================================
  Files           62       62              
  Lines         5323     5323              
===========================================
+ Hits          5106     5107       +1     
+ Misses         217      216       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levieggertcru levieggertcru marked this pull request as ready for review January 10, 2025 14:04
@levieggertcru
Copy link
Collaborator Author

NOTE: There will most likely need to be some tweaks to the renderer following this PR. Need to take a closer look at these elements in the renderer and see how this change effects these areas:

Tract Page
Tract Card
Training Page
Content
Accordion Section
Card Collection Page Card
Lesson Page
Multi Select
Tab
Form
CYOA Intro Page
CYOA Categories Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant