Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL upgrade and deterministic enum mocks #1

Merged
merged 2 commits into from
Oct 31, 2024
Merged

GraphQL upgrade and deterministic enum mocks #1

merged 2 commits into from
Oct 31, 2024

Conversation

canac
Copy link
Collaborator

@canac canac commented Oct 30, 2024

  • Upgrade graphql package to v16
  • Made enum mocks always return the same value instead of different values very test run

@canac canac self-assigned this Oct 30, 2024
@canac canac requested a review from dr-bizz October 30, 2024 21:53
@canac
Copy link
Collaborator Author

canac commented Oct 30, 2024

@dr-bizz You might also want to review the workflow I added. I committed it straight to master because I wasn't sure if I could try out creating a release and triggering the action if it were in a branch. I pretty much just copied it from cru-payments.

dr-bizz
dr-bizz approved these changes Oct 31, 2024
View reviewed changes
Copy link

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this into it's own repo. It will help us if we need to alter it again.

@canac canac merged commit 0447b60 into master Oct 31, 2024
2 checks passed
@canac canac deleted the ergonomck-improvements branch October 31, 2024 16:43
@canac canac mentioned this pull request Oct 31, 2024
Merged
3 tasks
@canac
Copy link
Collaborator Author

canac commented Nov 15, 2024

Fixes SurveyMonkey#166 and SurveyMonkey#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@canac canac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz